-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose functions to wait for tasks #260
Comments
Hi @ahmednfwela, there has been a long long long discussion about this subject, and I don't want to move this function to the public yet. |
Well the main problem is that the server completes the request instantly instead of the expected behavior of waiting until completion. This can be solved by using |
Indeed that's the current behavior, and the problem is the user can be locked until Meilisearch finally processes the task. This is my main concern with the whole waitForTask thing. In any case, all the other SDKs have this method publically, so I'm open to publicizing these methods for the Dart SDK if more users explicitly let us know their needs (a 👍 in the issue can work). |
I'll close this issue since this subject could be discussed more broadly in the integration-guides here meilisearch/integration-guides#243 |
The functions defined in
https://github.com/meilisearch/meilisearch-dart/blob/main/test/utils/wait_for.dart
should be exposed in the main library, in addition to
waitForTasks
The text was updated successfully, but these errors were encountered: