Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor SliceSelections ids propagation #420

Open
palucdev opened this issue Aug 23, 2018 · 0 comments
Open

Refactor SliceSelections ids propagation #420

palucdev opened this issue Aug 23, 2018 · 0 comments
Labels
Enhancement 🌪 Things that improve our project. Frontend 🖥 Stuff related to Frontend part. P2 Things with #2 Priority

Comments

@palucdev
Copy link
Member

Current Behavior

Slice selections IDs are auto incremented and set when new SliceSelection object is created. It is now coliding with Brush/Eraser Selector and in future can cause problem with other new tools.

Expected Behavior

We should use service that will keep track of IDs. Using this kind of component we can get next id, reset id counter and other possible id operations. Without auto ids we can create objects that will reuse other id without incrementing id pool.

Additional comment (optional)

Connected with #397

@palucdev palucdev added Enhancement 🌪 Things that improve our project. Frontend 🖥 Stuff related to Frontend part. P1 Things with #1 Priority labels Aug 23, 2018
@kolszewska kolszewska added this to the Sprint #4 milestone Aug 23, 2018
@palucdev palucdev self-assigned this Aug 25, 2018
@kolszewska kolszewska modified the milestones: Sprint #4, Sprint #5 Sep 4, 2018
@kolszewska kolszewska modified the milestones: Sprint #5, Sprint #6 Sep 17, 2018
@kolszewska kolszewska modified the milestones: Sprint #6, Sprint #7 Oct 8, 2018
@palucdev palucdev removed their assignment Nov 30, 2018
@palucdev palucdev added Backlog 🌍 P2 Things with #2 Priority and removed In Progress 🚀 P1 Things with #1 Priority P2 Things with #2 Priority labels Nov 30, 2018
@kolszewska kolszewska removed this from the Sprint #7 milestone Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement 🌪 Things that improve our project. Frontend 🖥 Stuff related to Frontend part. P2 Things with #2 Priority
Projects
None yet
Development

No branches or pull requests

3 participants