breaking(#234): replace users when core supports multiple facility_ids #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennsippell
changed the title
There was a problem hiding this comment.
Copilot reviewed 19 out of 19 changed files in this pull request and generated no comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposed change makes it so cht-user-management requires CHT Core 4.7 or higher. It is a breaking change which should affect no users because all projects are running 4.9 or above.
Closes #234
Closes #228
Closes #114
Closes #76
Changes:
chtApi.updateContactParentandUploader.linkContactAndPlacewhich were only required as workaround for Cannot create user for contacts created via Place Api cht-core#8674DisableUsersclass which handles users with multiple facilities by removing facility_ids during replacementTesting: I tested on CHT Core 4.6, 4.7, 4.11, and 4.15 (master)