Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load the cht-core enketo widgets #46

Closed
kennsippell opened this issue Apr 6, 2020 · 5 comments
Closed

Load the cht-core enketo widgets #46

kennsippell opened this issue Apr 6, 2020 · 5 comments

Comments

@kennsippell
Copy link
Member

Currently the cht-core enketo widgets aren't loaded into the test harness. Can we load them to make the forms in the harness more closely behave like the forms in the webapp?

@kennsippell
Copy link
Member Author

kennsippell commented Apr 7, 2020

This is pretty challenging:

  1. There is some weird syntax around some of the widgets that prevent them from building into our library. We can work around this with module rule { test: /\/enketo\/widgets/i, use: 'script-loader' } or alike.
  2. Several of the widgets directly call angular services (Android-datepicker, bikram-sambat-datepicker, db-object-widget, mrdt, notewidget, phone-widget, simprints). The angular services called are: Language, $translate, MRDT, Select2Search, Enketo, Markdown, Settings, DB, Simprints.

Is this depth of integration possible? Is this wise? What are the limits of the harness and when is the right time to just build an e2e test?

@kennsippell
Copy link
Member Author

kennsippell commented Apr 7, 2020

This depth of integration is maybe beyond the abilities of this framework :( Please re-activate this bug if you feel it is worthwhile to invest in this depth of integration.

@kennsippell
Copy link
Member Author

kennsippell commented Sep 9, 2021

Hope! Re-evaluate after Angular upgrading in 3.11?

@jkuester
Copy link
Contributor

jkuester commented Apr 2, 2024

@kennsippell do you think we can consider this issue to be addressed now? AFIK, pretty much all the widgets should load fine in the harness except for the db-object widget (which is being tracked in #184).

@kennsippell
Copy link
Member Author

Yep!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants