Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on moment.js #126

Open
kennsippell opened this issue Jun 28, 2021 · 0 comments
Open

Remove dependency on moment.js #126

kennsippell opened this issue Jun 28, 2021 · 0 comments

Comments

@kennsippell
Copy link
Member

Package.json contains both luxon and moment. #118 moves harness to use only Luxon for all datetime manipulation/interfaces, but the dependency on moment.js cannot yet be killed because of core dependency.

Seems like we should do something like this in the build script

ERROR in ./node_modules/cht-core-3-11/webapp/src/js/enketo/translator.js 1:15-32
Module not found: Error: Can't resolve 'moment' in '/home/runner/work/medic-conf-test-harness/medic-conf-test-harness/node_modules/cht-core-3-11/webapp/src/js/enketo'
resolve 'moment' in '/home/runner/work/medic-conf-test-harness/medic-conf-test-harness/node_modules/cht-core-3-11/webapp/src/js/enketo'
  Parsed request is a module
  using description file: /home/runner/work/medic-conf-test-harness/medic-conf-test-harness/node_modules/cht-core-3-11/webapp/package.json (relative path: ./src/js/enketo)
    resolve as module
      /home/runner/work/medic-conf-test-harness/medic-conf-test-harness/node_modules/cht-core-3-11/webapp/src/js/enketo/node_modules doesn't exist or is not a directory
      /home/runner/work/medic-conf-test-harness/medic-conf-test-harness/node_modules/cht-core-3-11/webapp/src/js/node_modules doesn't exist or is not a directory
      /home/runner/work/medic-conf-test-harness/medic-conf-test-harness/node_modules/cht-core-3-11/webapp/src/node_modules doesn't exist or is not a directory
      /home/runner/work/medic-conf-test-harness/medic-conf-test-harness/node_modules/cht-core-3-11/webapp/node_modules doesn't exist or is not a directory
      /home/runner/work/medic-conf-test-harness/medic-conf-test-harness/node_modules/cht-core-3-11/node_modules doesn't exist or is not a directory
      /home/runner/work/medic-conf-test-harness/medic-conf-test-harness/node_modules/node_modules doesn't exist or is not a directory
      looking for modules in /home/runner/work/medic-conf-test-harness/medic-conf-test-harness/node_modules
        single file module
          using description file: /home/runner/work/medic-conf-test-harness/medic-conf-test-harness/package.json (relative path: ./node_modules/moment)
            no extension
              Field 'browser' doesn't contain a valid alias configuration
              /home/runner/work/medic-conf-test-harness/medic-conf-test-harness/node_modules/moment doesn't exist
            .js
              Field 'browser' doesn't contain a valid alias configuration
              /home/runner/work/medic-conf-test-harness/medic-conf-test-harness/node_modules/moment.js doesn't exist
            .json
              Field 'browser' doesn't contain a valid alias configuration
              /home/runner/work/medic-conf-test-harness/medic-conf-test-harness/node_modules/moment.json doesn't exist
            .wasm
              Field 'browser' doesn't contain a valid alias configuration
              /home/runner/work/medic-conf-test-harness/medic-conf-test-harness/node_modules/moment.wasm doesn't exist
        /home/runner/work/medic-conf-test-harness/medic-conf-test-harness/node_modules/moment doesn't exist
      /home/runner/work/medic-conf-test-harness/node_modules doesn't exist or is not a directory
      /home/runner/work/node_modules doesn't exist or is not a directory
      /home/runner/node_modules doesn't exist or is not a directory
      /home/node_modules doesn't exist or is not a directory
      /node_modules doesn't exist or is not a directory
 @ ./ext/OpenrosaXpathEvaluatorBinding.js 7:17-73
 @ ./node_modules/enketo-core/src/js/Form-model.js 566:38-76
 @ ./node_modules/enketo-core/src/js/Form.js 3:16-41
 @ ./src/form-host/wireup.js 2:19-53
 @ ./src/form-host/index.js 2:19-38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant