Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish on FDroid #5

Open
sepo83 opened this issue Mar 21, 2021 · 6 comments
Open

Publish on FDroid #5

sepo83 opened this issue Mar 21, 2021 · 6 comments

Comments

@sepo83
Copy link
Contributor

sepo83 commented Mar 21, 2021

In the README you announced to publish the app on FDroid. Did you already start? If not I would offer some help; e.g. adapt your repo (e.g. create a pull request that adds metadata in fastlane structure) and prepare the merge-request to the fdroiddata repo.

@danielfoehrKn
Copy link
Collaborator

That would be amazing. I actually already started looking into it, but have postponed it after realizing that it is not as trivial as I thought.

Sorry I have been quite busy in the last few days and haven't monitored the issues properly.

@sepo83
Copy link
Contributor Author

sepo83 commented Apr 5, 2021

I have prepared most things:

I can basically build your app (my fork) with the fdroid toolchain. However, it complains about the included binary android-smartview-sdk-2.5.1.jar. I think on fdroid they do not like binaries with "unknown" content resp. without sourcecode. Can you replace that binary? Either by using an alternative with published sources or remove it (at least for fdroid builds).

@sepo83
Copy link
Contributor Author

sepo83 commented Apr 5, 2021

After solving the above mentioned issue the next steps would be:

  1. check the fdroiddata metadata file I have prepared (https://gitlab.com/sepo83/fdroiddata/-/blob/master/metadata/com.mediathekview.mobile.yml)
    • esp. check metadata like Categories, License, AuthorName, SourceCode, etc
    • check build instructions --> with this and the chnges from my PR I can build the app locally (currently only with --skip-scan in order to workaround the included binary issue from above)
  2. make a new release that includes all necessary changes (my PR + solving the included binary issue) and come back to me
    • I would sugest your tag the (future) releases with v<major>.<minor>.<patch> as it is also sugested by github
    • I will adapt com.mediathekview.mobile.yml for frdoiddata to the new release from step 2 and do a "final check"
  3. Finally you should do the merge-request to the fdroiddata-repo with the following steps:

New releases will be automtically published on fdroid. For this fdroiddata regulary extracts the latest version from pubspec.yml (master-branch) and looks for a git tag with this version.

Thanks for your great app!!!

@danielfoehrKn
Copy link
Collaborator

Thanks for the detailed guide & the help!

The binary it complains about is used for casting videos to Samsung TVs - unfortunately, it is not open source.
I'll try to create a flavor that excludes this binary (no TV casting for fdroid versions).

@danielfoehrKn
Copy link
Collaborator

Still working on removing the Samsung library in the fdroid build flavor. Having not much capacity to work on it though atm. Has to wait unfortunately still a bit.

@codenyte
Copy link

codenyte commented May 5, 2024

Any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants