Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requiring a lower version of punycode #372

Open
KristiyanVachev opened this issue Nov 14, 2018 · 1 comment
Open

Requiring a lower version of punycode #372

KristiyanVachev opened this issue Nov 14, 2018 · 1 comment

Comments

@KristiyanVachev
Copy link

KristiyanVachev commented Nov 14, 2018

Is it possible to lower the requirement for "punycode": "^2.1.0" to "punycode": "^1.4.1"?

The difference between punycode 1.4.1 and punycode 2.1.0 is just that the latter is written in ES6.

The current version supports recent versions of Node.js only. It provides a CommonJS module and an ES6 module. For the old version that offers the same functionality with broader support, including Rhino, Ringo, Narwhal, and web browsers, see v1.4.1.
-- punycode.js

When punycode 2.1.0 is used under IE11, it breaks with SCRIPT1002: Syntax error , because some ES6 constructs aren't supported.

I had this problem on the application I'm developing, and I fixed it by downgrading punycode to 1.4.1. Unfortunately your package doesn't allow a version lower than 2.1.0 and I'm afraid that it would break again if the punycode you are dependent on is used under IE11.

@rodneyrehm
Copy link
Member

what kind of setup are you using? require.js, webpack, …? all of these should allow you to override imports like punycode to use whatever version you need (or even transpile it using babel).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants