Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property sorting errors aren't fixed by npm run fix #25826

Open
1 of 2 tasks
caugner opened this issue Jan 31, 2025 · 0 comments · May be fixed by #25829
Open
1 of 2 tasks

Property sorting errors aren't fixed by npm run fix #25826

caugner opened this issue Jan 31, 2025 · 0 comments · May be fixed by #25829
Assignees
Labels
linter Issues or pull requests regarding the tests / linter of the JSON files.

Comments

@caugner
Copy link
Contributor

caugner commented Jan 31, 2025

What type of issue is this?

Infrastructure issue

What is the issue?

Noticed in #25825 at 397f188.

The linter fails and tells me to run npm run fix, but that doesn't actually apply any changes.

Style - 5 problems (5 errors, 0 warnings):
 ✖ browsers/edge.json - Error → Property sorting error on different number of lines:
    → Actual:   453
    → Expected: 454
   ◆ Tip: Run npm run fix to fix sorting automatically
 ✖ browsers/firefox.json - Error → Property sorting error on different number of lines:
    → Actual:   993
    → Expected: 996
   ◆ Tip: Run npm run fix to fix sorting automatically
 ✖ browsers/nodejs.json - Error → Property sorting error on different number of lines:
    → Actual:   739
    → Expected: 741
   ◆ Tip: Run npm run fix to fix sorting automatically
 ✖ browsers/safari.json - Error → Property sorting error on line #8:
      → Actual:           "flags", 
      → Expected:         "flags",
   ◆ Tip: Run npm run fix to fix sorting automatically
 ✖ browsers/safari_ios.json - Error → Property sorting error on line #8:
      → Actual:           "flags", 
      → Expected:         "flags",
   ◆ Tip: Run npm run fix to fix sorting automatically

What behavior were you expecting?

npm run fix should apply the fixes.

What version(s) of BCD is the issue present in?

  • The current BCD release
  • The current version of the main branch

Do you have anything more you want to share?

No response

@caugner caugner self-assigned this Jan 31, 2025
@caugner caugner added the linter Issues or pull requests regarding the tests / linter of the JSON files. label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linter Issues or pull requests regarding the tests / linter of the JSON files.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant