-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
marray
failures in scipy.stats
#71
Comments
I see a lot of places where it will be skipped where Adding some new standard functions like I'll work on this a bit this morning. Here are some things I'm coming across that I'll come back to later:
|
down to these now
|
I already have the PR for |
Cool. Can you merge the latest in SciPy and MArray and run more time? |
|
scipy/scipy#22222 will fix the |
I think a lot of the remaining errors about non-matching dtype are caused when |
Really? The fillvalue is supposed to be a scalar, https://data-apis.org/array-api/draft/API_specification/generated/array_api.full.html |
Related to data-apis/array-api-strict#55 then |
Well, it's a 0d array. I think that's reasonable because otherwise the dtype has to be specified manually. |
Yeah, but torch does not accept 0-D arrays |
Maybe torch is skipped? I'll take a closer look. Two other things: A lot of failures arise when an input sample is empty. The result for most statistics is NaN, but for MArrays, the result is often a masked element. (Think mean/var of an array with all masked elements; mean/var of an array with zero elements masked or otherwise.) In many cases I think this is what we'd expect, although I'm not sure how that should be reflected in the tests. The obvious thing is to special case the assertion of each of these tests. Another possibility is for the However, I saw that All that brings up something I've thought about that is a bit inconsistent with masked arrays: if |
That seems reasonable, at least for now! |
https://github.com/lucascolley/scipy/tree/c7124c86e97540c60731b3414e5456edfc2cecb8
failures: https://gist.github.com/lucascolley/932b227d170e736589e04b5aac8690f0
There are about 10 extra failures for
marray.array_api_strict
using https://github.com/lucascolley/scipy/tree/159424172b34c7d513bbcda3b3a8f11f44a61dd8.The text was updated successfully, but these errors were encountered: