Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the toolbox icon in the ZHA Toolkit integration component name? #264

Closed
Hedda opened this issue Sep 18, 2024 · 3 comments
Closed

Comments

@Hedda
Copy link
Contributor

Hedda commented Sep 18, 2024

Recommend remove toolbox icon in the ZHA Toolkit integration component name as it does not follow HA's name standard. See:

🧰 icon or no 🧰 icon, that is the question?

Suggest just remove special \ud83e\uddf0 character in name "name": "ZHA \ud83e\uddf0 Toolkit", for manifest.json

{
  "domain": "zha_toolkit",
  "name": "ZHA \ud83e\uddf0 Toolkit",
  "codeowners": ["@mdeweerd"],
  "dependencies": ["zha"],
  "documentation": "https://github.com/mdeweerd/zha-toolkit",
  "iot_class": "local_polling",
  "issue_tracker": "https://github.com/mdeweerd/zha-toolkit/issues",
  "requirements": ["aiofiles>=0.4.0", "pytz>=2016.10"],
  "version": "1.0.0"
}

https://github.com/mdeweerd/zha-toolkit/blob/main/custom_components/zha_toolkit/manifest.json

Ping @alexruffell

@alexruffell
Copy link

@Hedda - I agree the icon should be removed. I actually always mistake it for an old music cassette... showing age here. At least it is no longer before the name where it messed with the sorting, anyhow it is now in the middle and just looks off. Doing away with it is the best option in my opinion - especially if it doesn't follow HA frontend standards.

@Hedda
Copy link
Contributor Author

Hedda commented Sep 30, 2024

@mdeweerd Noted tested changing name in component manifest, wondering if changing just the same could break anything?

@mdeweerd
Copy link
Owner

Thanks. The icon was moved a bit further in one of the integrated PRs - thanks to the author. I gues this is ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants