Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: 404 Not found #208

Closed
3 tasks done
Ayushmaanagarwal1211 opened this issue Jun 5, 2024 · 11 comments
Closed
3 tasks done

Feat: 404 Not found #208

Ayushmaanagarwal1211 opened this issue Jun 5, 2024 · 11 comments
Assignees
Labels
assigned u r assigned to the issue enhancement New feature or request gssoc'24 level1 we need it web enhance try to make web impressive

Comments

@Ayushmaanagarwal1211
Copy link
Contributor

Describe the feature

I am thinking that user should be route to 404 page on entering unwanted path

Add ScreenShots

bandicam.2024-06-05.22-57-42-632.mp4

Record

  • I agree to follow this project's Code of Conduct
  • I'm a GSSOC'24 contributor
  • I want to work on this issue
@Ayushmaanagarwal1211 Ayushmaanagarwal1211 added the enhancement New feature or request label Jun 5, 2024
Copy link

github-actions bot commented Jun 5, 2024

Thank you for creating this issue! 🎉 We'll look into it as soon as possible. In the meantime, please make sure to provide all the necessary details and context. If you have any questions or additional information, feel free to add them here. Your contributions are highly appreciated! 😊

You can also check our CONTRIBUTING.md for guidelines on contributing to this project.

@mdazfar2 mdazfar2 added let you know pending this issue may be closed and removed let you know labels Jun 5, 2024
@mdazfar2
Copy link
Owner

mdazfar2 commented Jun 5, 2024

@Ayushmaanagarwal1211 how you can resolve this??

@shubhammjha22
Copy link
Contributor

@mdazfar2 hey i would like to work on this issue, and i think we can resolve this by either using Js and making routes defined in that so whenever a user enters a path which doesnt exist it will redirect them to the homepage instead.

For example if user enters - https://helpops-hub.vercel.app/random
it will be redirected to - https://helpops-hub.vercel.app/

@mdazfar2 mdazfar2 added let you know future requirement we dont need this, will let you know in future labels Jun 6, 2024
@mdazfar2
Copy link
Owner

mdazfar2 commented Jun 6, 2024

@shubhammjha22 as of now, we think we don't need this, will let you know in future, if there is need

@Ayushmaanagarwal1211
Copy link
Contributor Author

@mdazfar2 actually i found some ways to do this on internet using js to get the route an if the route is invalid then move to 404page.html

@mdazfar2 mdazfar2 added gssoc'24 level1 web enhance try to make web impressive assigned u r assigned to the issue we need it and removed let you know future requirement we dont need this, will let you know in future pending this issue may be closed labels Jun 6, 2024
@mdazfar2
Copy link
Owner

mdazfar2 commented Jun 6, 2024

@mdazfar2 actually i found some ways to do this on internet using js to get the route an if the route is invalid then move to 404page.html

@shubhammjha22 @Ayushmaanagarwal1211
assigned, go ahead

@Ayushmaanagarwal1211
Copy link
Contributor Author

Ok

@shubhammjha22
Copy link
Contributor

@mdazfar2 Hey, it doesn't seem necessary to assign two people to this issue. Since @Ayushmaanagarwal1211 was the first one to raise this issue i think he should be assigned .

@mdazfar2
Copy link
Owner

mdazfar2 commented Jun 6, 2024

@shubhammjha22 you are good man I'm unassigning you

@Ayushmaanagarwal1211
Copy link
Contributor Author

@mdazfar2 Hey, it doesn't seem necessary to assign two people to this issue. Since @Ayushmaanagarwal1211 was the first one to raise this issue i think he should be assigned .

Thanks bro for your kindness

Copy link

Hello @Ayushmaanagarwal1211! Your issue #208 has been closed. Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned u r assigned to the issue enhancement New feature or request gssoc'24 level1 we need it web enhance try to make web impressive
Projects
None yet
Development

No branches or pull requests

3 participants