Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Want to enhance the CONTRIBUTING.md file documentation #1351

Closed
muhafiz5814 opened this issue Sep 30, 2024 · 5 comments
Closed

Want to enhance the CONTRIBUTING.md file documentation #1351

muhafiz5814 opened this issue Sep 30, 2024 · 5 comments
Labels
question Further information is requested

Comments

@muhafiz5814
Copy link

There are some typos and some incomplete sentences I found while reading the contribution guide. Also there is some improvement in git commands.
I have already fixed these in my forked repo and will create a PR once you assign me this issue and will work on any review you provide.

Copy link

Thank you for creating this issue! 🎉 We'll look into it as soon as possible. In the meantime, please make sure to provide all the necessary details and context. If you have any questions or additional information, feel free to add them here. Your contributions are highly appreciated! 😊

You can also check our CONTRIBUTING.md for guidelines on contributing to this project.

@mdazfar2
Copy link
Owner

Hi @muhafiz5814,

Thank you for raising the issue! Could you please specify the changes you'd like to make and where you'd like to implement them? This information will help me assign the issue effectively.

@mdazfar2 mdazfar2 added the question Further information is requested label Sep 30, 2024
@muhafiz5814
Copy link
Author

Hi @muhafiz5814,

Thank you for raising the issue! Could you please specify the changes you'd like to make and where you'd like to implement them? This information will help me assign the issue effectively.

Yeah sure,
First line after the heading How to contribute should contain the link to existing issues also.
In local machine setup commands, command to create a new branch should contain switch instead of checkout as per latest git commands released.
Also there are some typos such as in line 90 - crate instead of create.

These are some changes I would like to make.

@mdazfar2
Copy link
Owner

mdazfar2 commented Oct 1, 2024

@muhafiz5814 Can you please raise issue for Ezyshop because we don't have any contributing guidelines please visit Ezyshop. Thank you!

Copy link

github-actions bot commented Oct 3, 2024

Hello @muhafiz5814! Your issue #1351 has been closed. Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants