Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small Improvements and Random Feature Idea List #550

Open
mcmonkey4eva opened this issue Jan 25, 2025 · 0 comments
Open

Small Improvements and Random Feature Idea List #550

mcmonkey4eva opened this issue Jan 25, 2025 · 0 comments
Labels
Easy PR Want to contribute? Here's a good thing to try Feature New feature or request

Comments

@mcmonkey4eva
Copy link
Member

mcmonkey4eva commented Jan 25, 2025

This issue is a list of various small things that could be improved, and random things that can be added.

The "small things" part is basically here to serve as a grab-bag of things for people looking to contribute to the project.
If you're wondering "but these are small and easy, why don't you just do them yourself?", two reasons:

  • 1: I want to encourage contribution. Swarm is free and open source, I don't get paid for this. I don't want to develop this project all alone, and having easy things to fix is a great way for new contributors to get started.
  • 2: Even small things take time. Finding where in the code to do it, editing it, testing it, testing for possible regressions, making sure the choices made about how to do it were right, etc. It takes time, and when you add up all the things to do... there's more things to do than time in the day for 1 person.

The "random ideas" part is things which aren't important enough to warrant a feature request on their own, but might be interesting.


ComfyUI Updates

  • Comfy now has /api/ routing prefix. Swarm should use this
  • Comfy now natively includes SaveImageWebsocket node, this should replace the SwarmSaveImageWS (keep the swarm node for backwards compat, but stop generating it)
  • PixArt Alpha/Sigma is native supported in comfy now (these models suck but probably worth supporting just on principle)
  • port more of the SwarmKSampler features to work with SamplerCustomAdvanced

Debugging and wotnot

  • detect zip/ckpt header when safetensors fails to load and give a better error message for wrong file extensions
  • model 'view raw metadata' button and a way to clear non-modelspec metadata easily in UI
  • network diagnostics in resource usage section of the Server tab - eg total number of connections, etc.

UI Improvements

  • refresh button should disable+reenable when refresh ends, as a visual indicator. Maybe a loading symbol?
  • put cascade latent compression behind a cascade feature lock and move to regular Sampling (ie match flux guidance handling)
  • param group naming parens, eg Init Image (Img2Img) with that little gray-out effect that I have in dropdown selectors
  • "Create New Wildcard" or Preset should prefix current folder path in the name box
  • loras in a preset should add not replace
  • preset names should be filtered to use filename-compatible IDs internally (eg no wonky slashes)
  • Path settings change should force a client modellist refresh just to avoid confusion
  • Metadata display on page should autotranslate display names (eg Sampler name should show DPM++ 2M not dpmpp_2m)
  • prompt "+" button should have a "Add Image Prompt" maybe
  • update options: way to update to latest release vs latest dev (via git calls)
  • more control over comfy & comfy node updates. Button to trigger an update check manually (next to the swarm button?) a swarm-managed node listing tab, etc.

Internal Improvements

  • comfyuicustomworkflow param should work just like raw workflow for parameter autogeneration - setup and run custom workflow via API #383
  • don't emit "//cid=" syntax in output prompt (to avoid original_prompt when there's no change for segments)

Features to test

@mcmonkey4eva mcmonkey4eva added Easy PR Want to contribute? Here's a good thing to try Feature New feature or request labels Jan 25, 2025
@mcmonkey4eva mcmonkey4eva pinned this issue Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Easy PR Want to contribute? Here's a good thing to try Feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant