Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

listener_kwargs in "prices_file_to_data_frame()" #19

Open
nachouve opened this issue Apr 7, 2022 · 5 comments
Open

listener_kwargs in "prices_file_to_data_frame()" #19

nachouve opened this issue Apr 7, 2022 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@nachouve
Copy link

nachouve commented Apr 7, 2022

Would be possible pass some arguments to the listener of the function prices_file_to_data_frame()?

It would be great to pass a listener_kwargs dict to get a subset of prices.
Something similar to https://betcode-org.github.io/flumine/quickstart/#listener-kwargs

@mberk mberk added the enhancement New feature or request label Apr 7, 2022
@mberk mberk self-assigned this Apr 7, 2022
@mberk
Copy link
Owner

mberk commented Apr 7, 2022

Yes, happy to add this. It wouldn't really be listener_kwargs per se as these get actioned by flumine not betfairlightweight. With that in mind, anything else you would like to be able to filter other than inplay/seconds to market start?

@nachouve
Copy link
Author

nachouve commented Apr 8, 2022

I have tried to implement that filter myself. I saw that and gave up....
But if you skip all the unwanted prices lines before transforming them into python objects by the generator, I think it speeds up some analysis I do, doesn't it?

About more filters... Maybe filtering only one prices side or some specific selection_ids could be good too!

@nachouve
Copy link
Author

nachouve commented Apr 8, 2022

Do you think is it possible to move the "max_depth" to the stream generator?
It can be a good improvement too.

@mberk
Copy link
Owner

mberk commented Apr 9, 2022

I think these are all questions for @liampauling re: betfairlightweight. I would only be applying the filtering after having generated all of the market books. If you want increased performance then #18 is your best bet

@liampauling
Copy link
Contributor

With some extra code listener_kwargs can be passed down to bflw now however as Mo mentioned this is now redundant due to #18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants