-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dotted-quad support for IPv4 subnet masks #30
Comments
That seems possible. A PR that did this with appropriate tests and documentation would likely be accepted. |
I was already able to use use Net::Works::Util::_integer_address_to_string($net->_subnet_integer) for generting the dotted-quad output. |
Yeah, I could see guessing potentially leading to confusion in some cases. I suppose an additional parameter, e.g., |
@oschwald Before I start with this pull-request, can you be so kind to look at my fork which uses binary representation instead of integer/Math::Int128? |
I've rebased my fork with my commits from 2014 against current main and called it main, so my original modifications are also viewable in the still existing master branch. |
@abraxxa, sure, do you have a link to what you want me to review? |
The main branch in my fork please. |
@oschwald friendly reminder ;-) |
Sorry for the delay. At a high level, most of the changes seem good. It will be easier to review once there is a PR that I can comment on. |
I have to work with a product that returns IPv4 networks with the subnet mask in dotted-quad notation and need to parse those.
Can we add support for in- and output of this format without breaking things?
Thanks!
The text was updated successfully, but these errors were encountered: