You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
listen_port being passed on to prometheus.start_http_server makes it a whole listen_address, rather than just a port, making configs look confusing when you actually need not-just-a-port in there.
Perhaps it'd be worth to rename it, keeping the existing one as a deprecated alias for a while?
metrics in the configuration only exposes port as a configurable, making it tricky to listen on non-standard addresses if needed.
The text was updated successfully, but these errors were encountered:
prometheus_client.start_http_server's first argument seems to be specifically a port as an integer, not an address? The second argument is addr, making that configurable might be useful
As for renaming config fields, the config update system exists specifically to support legacy field names without any fallbacks in the actual code.
Hmm, indeed – seems like we've been misusing it for quite a while, and it's been working due to a happy accident more than anything else...
tadzik
changed the title
metrics.listen_port is actually a listen-in-general
Expose the addr bit of prometheus' start_http_server() in the config
Nov 1, 2021
listen_port
being passed on toprometheus.start_http_server
makes it a whole listen_address, rather than just a port, making configs look confusing when you actually need not-just-a-port in there.Perhaps it'd be worth to rename it, keeping the existing one as a deprecated alias for a while?metrics
in the configuration only exposesport
as a configurable, making it tricky to listen on non-standard addresses if needed.The text was updated successfully, but these errors were encountered: