-
-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
image height should used in the bandwidth chooser instead of image width #58
Comments
I went through the code and noticed that Would you mind filling in a PR or want me to take this one? |
if it would be a python or rust project, i would offer you a PR immediately, but unfortunately i'm not used to TS and all the mysteries of its build systems, although i could perhaps guess the right solution in this particular case by chance. ;) |
you'll now find a proposal to fix this issue in PR #59 beside eliminating some other flaws. btw.: i really like your software and use it frequently in my own work! |
@mash-graz Thank you for your kind words! It looks pretty cool to see indigo in action in that screenshot! :) |
Describe the bug
right now the bandwidth chooser in the right bottom of the player shows the image width instead of height for the variant entries in the HLS playlist. that's rather irritating, because all other players use the image height in this place. image height is also commonly used in the video tech world eg. to refer to FHD as "1080p" etc.
The text was updated successfully, but these errors were encountered: