Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use within another div an issue? #5

Open
protoolreviews opened this issue Aug 29, 2013 · 1 comment
Open

Use within another div an issue? #5

protoolreviews opened this issue Aug 29, 2013 · 1 comment

Comments

@protoolreviews
Copy link

I have implemented this code on my site for the top 728x90 banner:

http://www.protoolreviews.com

Unfortunately, though the js file seems to be called correctly and all other code insertions seem to match your example page, I can't get the banner to resize.

Is it possible that the location of the banner within the theme is preventing the script from properly executing?

I'd love any feedback you may have on this.

@mattnish
Copy link
Owner

I've gotten your banner to resize using this jquery in console:
jQuery('#div-gpt-ad-1377291088288-3').rad();

The plugin doesn't handle it well though. It needs to have an actual container it can comfortably expand to. Maybe you can put a width of "width: calc(100% - 280px);" (+other browsers) on your #top-ad div on desktop and then an width of "100%" to your #top-ad div when the responsive CSS triggers at 767px.

Good looking site.

Matt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants