Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine draw-tsp-path.py and draw-tsp-path-concorde.py into one file #6

Open
matthras opened this issue Jul 18, 2020 · 0 comments
Open
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@matthras
Copy link
Owner

matthras commented Jul 18, 2020

It finally clicked for me why I was so annoyed about having two separate scripts despite both of them using the same 'canvas' for drawing to PNG files so I was effectively having code duplication.

In general I'm thinking the general flow process should be: "Check if there's a Concorde solution, if not, solve for a solution using OR-tools. Draw image" because in general the Concorde solution returns a better solution but for licensing purposes some people might want to keep things strictly in Python, so it's nice to have the versatility there.

I'm going to work on this for #2 to begin with, then once I've figured that out I'll apply it to this one as well.

@matthras matthras added enhancement New feature or request good first issue Good for newcomers labels Jul 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant