Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove code: No need to execute smart contract before tx admission into mempool #2601

Open
snail-inO opened this issue Aug 6, 2024 · 1 comment

Comments

@snail-inO
Copy link

🌟 Feature Request

📝 Description

A transaction will be executed twice in the current implementation: 1) before mempool admission, 2) block validation (i.e., when it is to be included in the next block).

I don't find it necessary to execute the smart contract twice, and reducing it to one contract execution should help improve the sequencer's performance.

I suggest removing the code of pre-mempool contract execution.
I did remove the related code and found the zkSync sequencer was still functioning.

🤔 Rationale

Benefits

  • Reducing overall computation overhead and improving performance

📋 Additional Context

The code for executing a contract before mempool is in the following link. It is also the code that has been suggested to be removed.

let execution_output = self

@JitanderVerma
Copy link

Jmm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants