Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing diagnostic for debugger:autoInitialize() #22

Open
Ukendio opened this issue Jan 12, 2024 · 0 comments
Open

Missing diagnostic for debugger:autoInitialize() #22

Ukendio opened this issue Jan 12, 2024 · 0 comments
Labels
good first issue Good for newcomers improvement An imperfection we can make better
Milestone

Comments

@Ukendio
Copy link
Member

Ukendio commented Jan 12, 2024

Current behavior

Currently if you initialize the debugger after you have begun the loop it will silence error and the debugger will not popup when you toggle it.

Proposed improvement

We can expose a flag like loop.started and when :autoInitialize is called, we check if the passed loop has the flag enabled. If it is enabled, it should error with a message stating that it needs to be called before the loop begins.

Additional context

Someone in the roblox-ts server encountered this issue with Matter where they couldnt get the debugger up because they had initialized it after the loop started. Personally when I tried helping it took me a good few minutes to figure it out.

@Ukendio Ukendio added improvement An imperfection we can make better good first issue Good for newcomers labels Jan 12, 2024
@LastTalon LastTalon added this to the v0.9.0 milestone Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers improvement An imperfection we can make better
Projects
None yet
Development

No branches or pull requests

2 participants