Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull Request merge progress. #4

Closed
tatokis opened this issue Dec 9, 2016 · 10 comments
Closed

Pull Request merge progress. #4

tatokis opened this issue Dec 9, 2016 · 10 comments
Assignees
Milestone

Comments

@tatokis tatokis self-assigned this Dec 9, 2016
@tatokis tatokis changed the title Pull Requests merge progress. Pull Request merge progress. Dec 9, 2016
@mattanger
Copy link
Owner

mattanger commented Dec 11, 2016 via email

@tatokis
Copy link
Collaborator Author

tatokis commented Dec 27, 2016

I've brought newfx up to date, and I made some changes so that it compiles on linux.
Could someone test it (ckb-mviz) on linux?

Just want to be sure that it isn't a case of "it only works on my machine".

@fleischie
Copy link
Collaborator

fleischie commented Dec 27, 2016

@tatokis what needs to bei tested? I can check, whether it builds and the daemon/GUI starts without crashing. But I don't have my keyboard with me over the holidays.

@mattanger
Copy link
Owner

mattanger commented Dec 27, 2016 via email

@tatokis
Copy link
Collaborator Author

tatokis commented Dec 27, 2016 via email

@fleischie
Copy link
Collaborator

@tatokis Compiles and daemon + GUI runs (only basic settings, because of no keyboard).

I couldn't run ckb-mviz though, because (again) of no keyboard.

@tatokis
Copy link
Collaborator Author

tatokis commented Dec 27, 2016

Alright, thanks

@mattanger
Copy link
Owner

Builds find and works fine with my keyboard. I do have pulseaudio. I'll try to build it on a vm without pulse sometime today.

@tatokis
Copy link
Collaborator Author

tatokis commented Apr 3, 2017

Regarding ccMSC/ckb#508 do we merge it or not?
Otherwise this issue should be closed.

@tatokis
Copy link
Collaborator Author

tatokis commented Apr 3, 2017

<l2y> -f is a good thing, but that line should've changed since the PR was made and it's easier to just add it manually

Fair enough point

@tatokis tatokis closed this as completed Apr 3, 2017
ghost pushed a commit that referenced this issue Apr 10, 2017
@ghost ghost added the resolved label Apr 10, 2017
@ghost ghost added this to the 0.2.8 milestone Apr 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants