Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rageshake server should concatenate log files of the same name pattern into a single stream #46

Open
michaelkaye opened this issue Jan 19, 2022 · 2 comments

Comments

@michaelkaye
Copy link
Contributor

Is your feature request related to a problem? Please describe.
When i download seven logs i have to juggle opening multiple files to read all logs in an order. It would be good to render all related logs in a single stream rather than have to juggle multiple files.

Describe the solution you'd like

Enable configuration of some regex matches that are aggregated together, for example:

log-1.log.gz
log-2.log.gz
...
log-49.log.gz

if a configuration file was given a regex of "log-([0-9]*).log.gz" and turn into a single file or virtual file containing logs ordered by time.

Describe alternatives you've considered
User-side scripts exist but are occasionally confused if log files come out of order.

Additional context
This might be harder than it looks ; some clients provide log files in a round-robin fashion, so finding the first log is hard if it's at the beginning.

Some other clients provide multiple streams which need to be sorted individually - and some different clients could create log streams that need to be treated differently.

This might be an aspiration rather than a practical change; possibly requiring clients to be updated to support some concept of sorting or grouping.

@t3chguy
Copy link
Member

t3chguy commented Jan 24, 2022

This would not be great for Web rageshakes, as each file represents a session (between reloads) and breaks up the logs quite nicely.

@michaelkaye
Copy link
Contributor Author

Ah, for some clients there's more of a need as there are real round robin logs going on. I think the setup might just be "and also offer a button for bulk download" rather than "replace existing log file format with bulk download". Or maybe we just say that element-web formatted logs are not one stream.

I wonder if we should try to make sure the "instance--" filename is preserved into the log server, rather than having everything overwritten with "logs-.txt" by the rageshake server - i imagine that'll be beneficial for finding logs at a certain time.

Though now i look at it; having the random number there will mean it'll not sort numerically in time order, so maybe that's not a good naming scheme :|

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants