Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'append_to_pre_release_tag' returns the branch name when provided an empty string #122

Open
victorhearnyeates opened this issue Apr 11, 2022 · 5 comments

Comments

@victorhearnyeates
Copy link

I want to create a new tag, but have no suffix added by the action. However the use of the ternary operator in the action.ts code means that it interepts this empty string as not providing a value and instead uses the default of the branch name.

https://github.com/mathieudutour/github-tag-action/blob/master/src/action.ts#L65

Basically, we need some way to be able to provide an empty string if we want nothing appended

@diogomonte
Copy link

I am looking for the same solution.

@epignatelli
Copy link

Duplicate of #163

And I also have the same issue.

@mikejflex
Copy link

You could set all branches to be release branches so it generates a tag like main by default:

      - name: Push patch tag
        id: push_patch_tag
        uses: mathieudutour/[email protected]
        with:
          github_token: ${{ secrets.GH_TOKEN }}
          # Ensure this branch is considered a release and it gets a normal tag
          release_branches: .*

@idasilva
Copy link

You could set all branches to be release branches so it generates a tag like main by default:

      - name: Push patch tag
        id: push_patch_tag
        uses: mathieudutour/[email protected]
        with:
          github_token: ${{ secrets.GH_TOKEN }}
          # Ensure this branch is considered a release and it gets a normal tag
          release_branches: .*

Thank you so much its works for me, but i thinks its nice to consider append nothing if we dont especify anything on append_to_pre_release_tag .

@noedev86
Copy link

up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants