Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spinner is displayed in addition to the table loading state in Record page #4169

Open
pavish opened this issue Jan 24, 2025 · 0 comments
Open
Labels
good first issue Everything in "Help wanted", PLUS being relatively easy and straightforward to implement. help wanted Community contributors can implement this ready Ready for implementation regression work: frontend Related to frontend code in the mathesar_ui directory
Milestone

Comments

@pavish
Copy link
Member

pavish commented Jan 24, 2025

Description

  • Open a record page for a table which has FK references to it.
    • Eg., (Bike Shop schema -> Customers table -> 2 (Andrew Haley))
    • Notice that the Related Records section displays the Service Requests table.
  • Click Refresh on any of the Related Records tables.
    • Eg., Service Requests table
  • Notice that there is a loading spinner shown which causes the table to move down and then up after it finishes loading. There is also a loading state indicator in the table.
Screen.Recording.2025-01-24.at.4.30.00.PM.mov

Expected behavior

  • The spinner should not be displayed while the table is reloading. It should be displayed only when the table loads for the first time.
@pavish pavish added good first issue Everything in "Help wanted", PLUS being relatively easy and straightforward to implement. help wanted Community contributors can implement this ready Ready for implementation work: frontend Related to frontend code in the mathesar_ui directory labels Jan 24, 2025
@pavish pavish added this to the Backlog milestone Jan 24, 2025
@pavish pavish changed the title Spinner is displayed in additional to default table loading state in Record page Spinner is displayed in addition to the table loading state in Record page Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Everything in "Help wanted", PLUS being relatively easy and straightforward to implement. help wanted Community contributors can implement this ready Ready for implementation regression work: frontend Related to frontend code in the mathesar_ui directory
Projects
None yet
Development

No branches or pull requests

1 participant