-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task Deprecation API #63
Comments
Actually, having this be part of the materials endpoint probably makes sense, since this is where the other deprecated task information is held. |
|
This is not the global deprecated true/false but the list of deprecated task_ids, I'm fine with it being part of the materials endpoint though, that seems sensible since it's already in the materials doc. |
The ideal place for this would be part of the tasks endpoint, but this isn't contained in the task doc itself (it's built information), so it's a little tricky. |
Oh gotcha, you mean the data in |
I'll defer to your judgement on that. It's tricky because I think the API should reflect the underlying document model as much as possible (to make it more obvious to someone examining the builders etc where that information came from), but this is semantically closer to |
Yeah, I generally agree with you. I will start with it under the tasks endpoint, and we can always move it later. |
Endpoint is added, but |
Is |
No, it isn't but I closed this issue here and opened a new one in the emmet repo since it is a builder problem. |
Perfect, just going to cross-link the issue here for reference: materialsproject/emmet#383 |
This doesn't come directly from the tasks doc iirc so should probably be a separate endpoint.
Ideally, this would return a simple
{deprecated: true/false, deprecation_reason: str}
(Under the current build process, deprecation reason will have to be empty)
The text was updated successfully, but these errors were encountered: