From fef28d9454871cab010c529b48314ea4fa5f2195 Mon Sep 17 00:00:00 2001 From: Anton Kuts Date: Mon, 14 Aug 2023 22:09:50 +0300 Subject: [PATCH 1/3] completed task 'stars' --- .bemlintrc.json | 16 ++++++++++++++++ readme.md | 4 ++-- src/index.html | 51 +++++++++++++++++++++++++++++++++++++++++++++++-- src/style.css | 35 +++++++++++++++++++++++++++++++++ 4 files changed, 102 insertions(+), 4 deletions(-) create mode 100644 .bemlintrc.json diff --git a/.bemlintrc.json b/.bemlintrc.json new file mode 100644 index 0000000000..22a597e54f --- /dev/null +++ b/.bemlintrc.json @@ -0,0 +1,16 @@ +{ + "elementDivider": "__", + "modifierDivider": "--", + "ignore": [ + "node_modules", + "dist" + ], + "rules": { + "one-block": true, + "one-element": true, + "element-inside-parent-block": true, + "no-double-element": true, + "no-neighbour-parent-block": true, + "modifiable-class": true + } +} diff --git a/readme.md b/readme.md index 67cabc463e..ca93ac42ef 100644 --- a/readme.md +++ b/readme.md @@ -1,7 +1,7 @@ # Stars block Replace `` with your Github username and copy the links to Pull Request description: -- [DEMO LINK](https://.github.io/layout_stars/) -- [TEST REPORT LINK](https://.github.io/layout_stars/report/html_report/) +- [DEMO LINK](https://TKuts.github.io/layout_stars/) +- [TEST REPORT LINK](https://TKuts.github.io/layout_stars/report/html_report/) > Follow [this instructions](https://mate-academy.github.io/layout_task-guideline) ___ diff --git a/src/index.html b/src/index.html index 3963c1c4cd..768b85b472 100644 --- a/src/index.html +++ b/src/index.html @@ -3,11 +3,58 @@ + content="width=device-width, user-scalable=no, initial-scale=1.0, maximum-scale=1.0, minimum-scale=1.0"> Stars -

Stars

+
+
+
+
+
+
+
+ +
+
+
+
+
+
+
+ +
+
+
+
+
+
+
+ +
+
+
+
+
+
+
+ +
+
+
+
+
+
+
+ +
+
+
+
+
+
+
+ diff --git a/src/style.css b/src/style.css index e69de29bb2..79af854655 100644 --- a/src/style.css +++ b/src/style.css @@ -0,0 +1,35 @@ +* { + margin: 0; +} + +.stars { + display: flex; +} + +.stars :last-child { + margin: 0; +} + +.stars__star { + width: 16px; + height: 16px; + background-repeat: no-repeat; + margin-right: 4px; + background-position: 50%; +} + +.stars--0 :nth-child(-n + 5), +.stars--1 :nth-child(n + 2), +.stars--2 :nth-child(n + 3), +.stars--3 :nth-child(n + 4), +.stars--4 :nth-child(n + 5) { + background-image: url("./images/star.svg"); +} + +.stars--1 :first-child, +.stars--2 :nth-child(-n + 2), +.stars--3 :nth-child(-n + 3), +.stars--4 :nth-child(-n + 4), +.stars--5 :nth-child(-n + 5) { + background-image: url(./images/star-active.svg); +} From b603b7d2fac4684147fede87fde9a6a59c107a5c Mon Sep 17 00:00:00 2001 From: Anton Kuts Date: Tue, 15 Aug 2023 19:59:26 +0300 Subject: [PATCH 2/3] fixed mistakes --- src/index.html | 1 - src/style.css | 7 +++---- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/src/index.html b/src/index.html index 768b85b472..a59319b215 100644 --- a/src/index.html +++ b/src/index.html @@ -56,5 +56,4 @@
- diff --git a/src/style.css b/src/style.css index 79af854655..6f5fccabb2 100644 --- a/src/style.css +++ b/src/style.css @@ -6,15 +6,14 @@ display: flex; } -.stars :last-child { - margin: 0; +.stars :not(:first-child) { + margin-left: 4px; } .stars__star { width: 16px; height: 16px; background-repeat: no-repeat; - margin-right: 4px; background-position: 50%; } @@ -31,5 +30,5 @@ .stars--3 :nth-child(-n + 3), .stars--4 :nth-child(-n + 4), .stars--5 :nth-child(-n + 5) { - background-image: url(./images/star-active.svg); + background-image: url("./images/star-active.svg"); } From aff61df0cf64ccddb8eea6cfaf84cf530f7c01fd Mon Sep 17 00:00:00 2001 From: Anton Kuts Date: Tue, 15 Aug 2023 23:28:46 +0300 Subject: [PATCH 3/3] fixed a bug with duplicate code --- src/style.css | 17 +++++------------ 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/src/style.css b/src/style.css index 6f5fccabb2..ef31df510d 100644 --- a/src/style.css +++ b/src/style.css @@ -15,20 +15,13 @@ height: 16px; background-repeat: no-repeat; background-position: 50%; -} - -.stars--0 :nth-child(-n + 5), -.stars--1 :nth-child(n + 2), -.stars--2 :nth-child(n + 3), -.stars--3 :nth-child(n + 4), -.stars--4 :nth-child(n + 5) { background-image: url("./images/star.svg"); } -.stars--1 :first-child, -.stars--2 :nth-child(-n + 2), -.stars--3 :nth-child(-n + 3), -.stars--4 :nth-child(-n + 4), -.stars--5 :nth-child(-n + 5) { +.stars--1 .stars__star:nth-child(-n + 1), +.stars--2 .stars__star:nth-child(-n + 2), +.stars--3 .stars__star:nth-child(-n + 3), +.stars--4 .stars__star:nth-child(-n + 4), +.stars--5 .stars__star:nth-child(-n + 5) { background-image: url("./images/star-active.svg"); }