Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with checksum explanation #364

Open
dehem70 opened this issue Oct 21, 2024 · 0 comments
Open

Issue with checksum explanation #364

dehem70 opened this issue Oct 21, 2024 · 0 comments

Comments

@dehem70
Copy link

dehem70 commented Oct 21, 2024

Hello

On the file docs/learn/operation-format-execution.mdx, for the explanation of the checksum verification, the doc says :
- serialize the operation ID in binary format (see above)
- compute the SHA256 hash of the binary serialization
- append the first 4 bytes of the sha256 hash at the end of the binary serialization of the ID. This is used as a checksum to detect typing errors as operation IDs are also meant to be written on paper by humans.

In reality it is :
- compute the SHA256 hash of the SHA256 hash of the binary serialization

The serialization of the binary => A
Computing sha256(sha256(A)
the first 4 bytes of this result are appended at the end of the binary serialization (A).

This process is present many time on the document.

Thanks for the correction

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant