Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable service fee on Redeem #547

Open
3 tasks
loonggamma opened this issue Feb 19, 2024 · 0 comments
Open
3 tasks

Enable service fee on Redeem #547

loonggamma opened this issue Feb 19, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@loonggamma
Copy link

loonggamma commented Feb 19, 2024

Context
After Mainnet bridge v1 is launched, in up to 1 month after we will initiate the collection of service fees on the Redeem flow, the 'claim' transaction step.

The ability to set the service fee is already implemented on the Smart Contract. The issue concerns testing and implementing the cost of service fee in the frontend.

User flow

  1. User arrives to the index page.
  2. User connects wallets and selects the Redeem flow (Massa -> Ethereum)
  3. User enters an amount to redeem (user didn't receive any errors of insufficient balance)
  4. User sees the bridge service fee of N% applied to his token amount. User understands the total amount of token he will receive after deducing the service fee.
  5. User sees the bridge fee and receiving amount for each active claim.

How to

  • Test the Backend and Smart Contract functionality of the service fee imposed on Redeem. Implement needed changes if any.

  • Design the solution on the UI that is easy to understand for the end-user redeeming tokens. @LucasF243
    That means: user must understand: the amount of service fee we take in token + the receiving amount on his wallet.
    a. User should know this before initiating the approve/burn operation on Massa.
    b. User should have the same info, once he is requested to sign the Claim operation: 1. from main flow, and 2. for each active claim on the Claim page.

  • Implement the frontend based on designs.

Technical details
Give the technical insights so anyone in the team can tackle the tasks - Dev

QA testing
Does this task require some QA tests ?
If yes, explain how to validate it

@loonggamma loonggamma added the enhancement New feature or request label Feb 19, 2024
@loonggamma loonggamma added this to the Post V1 milestone Feb 19, 2024
@Thykof Thykof self-assigned this Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants