Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify Mint Timeout and Refactor WarningLayout.tsx #508

Open
1 of 2 tasks
pivilartisant opened this issue Feb 12, 2024 · 2 comments
Open
1 of 2 tasks

Verify Mint Timeout and Refactor WarningLayout.tsx #508

pivilartisant opened this issue Feb 12, 2024 · 2 comments
Assignees
@pivilartisant
Labels
enhancement New feature or request P3 Low level priority
Milestone
Post V1

Comments

@pivilartisant
Copy link
Contributor

pivilartisant commented Feb 12, 2024 •
edited
Loading

We need to verify that mint timeout is still working.

  • Check if function is still working -> timeout is located in fn: waitForMintEvent() at src/custom/bridge/massa-utils.ts
  • Update src/pages/Index/Layouts/LoadingLayout/WarningLayout.tsx to be mintTimeout specific (awaiting instructions to implement (or not) new designs)
@pivilartisant pivilartisant changed the title Verify Mint Timeout Verify Mint Timeout and Refactor WarningLayout.tsx Feb 12, 2024
@pivilartisant pivilartisant added the enhancement New feature or request label Feb 12, 2024
@pivilartisant pivilartisant added this to the Front for Mainnet milestone Feb 12, 2024
@loonggamma loonggamma added the P2 Mid level priority label Feb 13, 2024
@pivilartisant pivilartisant self-assigned this Feb 21, 2024
@pivilartisant
Copy link
Contributor Author

pivilartisant commented Feb 21, 2024 •
edited
Loading

Current implementation of mint timeout:
Screenshot 2024-02-21 at 15 24 33

@pivilartisant
Copy link
Contributor Author

Instructions to do before closing issue : Let's do this: let's wait until the mainnt mode is live and carefully test the time it takes to get TOKEN_MINTED event. i think 5 minutes should be sufficient in any case on mainnet but we need to test to be sure

@loonggamma loonggamma added P3 Low level priority and removed P2 Mid level priority labels Mar 27, 2024
@loonggamma loonggamma modified the milestones: Front for Mainnet, Post V1 Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pivilartisant pivilartisant

Labels
enhancement New feature or request P3 Low level priority
Projects
None yet
Milestone
Post V1
Development

No branches or pull requests
2 participants
@pivilartisant @loonggamma