Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Common shortcut for comment/uncomment is missing #432

Closed
3 tasks done
bencodesall opened this issue Nov 16, 2023 · 4 comments
Closed
3 tasks done

[Bug]: Common shortcut for comment/uncomment is missing #432

bencodesall opened this issue Nov 16, 2023 · 4 comments

Comments

@bencodesall
Copy link

Describe the bug

Not sure if this is an apple silicon specific issue but ⌘+/ does not work to comment/uncomment the selected code. I could have sworn that this worked previously. ¯l_(ツ)_l¯

Otherwise I love this thing. Great job

Stats:
Version: 3.10.0
Electron: 16.2.3
Chrome: 96.0.4664.174
Node.js: 16.9.1
V8: 9.6.180.23-electron.0
OS: Darwin arm64 22.6.0

To reproduce

  1. Go to ... code snippet
  2. Select ... lines of code
  3. Press the ... "⌘" and "/" keys
  4. Watch ... the lines toggle between commented / uncommented
  5. Nothing happens

Version

3.10.0

OS

macOS Ventura 13.6.2

Validations

@antonreshetov
Copy link
Member

Shortcuts cannot be bugs by definition. This is a specific feature of the editor, it may or may not have this shortcut.

@bencodesall
Copy link
Author

In a strictly software engineering sense, you are correct. However from a UX/CX context, of the primary users being developers, this could be considered a usability flaw (or a "type" of usability "bug" even if not pedantically a technical "bug" per se.)

So what you are saying is that NOT having the ability to comment/uncomment is a specific, intentional feature of massCode "editor"? I apologize for pressing the issue, but every "editor" I've ever used has a "shortcut" (feature, ... thing) that allows quick keystroke commenting/uncommenting of code.

Add it to your backlog, or do not. It's a nice-to-have and not ultimately critical. Still, I don't really understand why you say ...

... it may or may not have this shortcut

... can you elaborate on that bit?

@antonreshetov antonreshetov reopened this Nov 17, 2023
@antonreshetov
Copy link
Member

First of all, this is not a bug, right?

Second, the experience of using any applications is a personal experience, I think it is wrong to project it on everyone. For example, the last editor I used did not have this shortcode. Also, under the hood, massCode uses codemirror 5 and it does not have this functionality by default.

Third, I'm not arguing that it's not an interesting feature, so let it be a suggestion.

In general, this is more of a discussion, and there is a separate page for discussions.

@bencodesall
Copy link
Author

That's fair.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants