Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR #426 contains code updates on KNet Connect SDK shall be tested #427

Open
masesdevelopers opened this issue Feb 29, 2024 · 2 comments
Open

PR #426 contains code updates on KNet Connect SDK shall be tested #427

masesdevelopers opened this issue Feb 29, 2024 · 2 comments
Assignees
@masesdevelopers
Labels
KNetConnectSDK KNetConnectSDK related issue

Comments

@masesdevelopers
Copy link
Contributor 

          This PR contains changes on KNet Connect SDK that can introduce bugs: make a test on it to verify compatibility.

Originally posted by @masesdevelopers in #426 (comment)
@masesdevelopers masesdevelopers changed the title PR 426 contains code updates on KNet Connect SDK shall be tested PR #426 contains code updates on KNet Connect SDK shall be tested Feb 29, 2024
@masesdevelopers masesdevelopers self-assigned this Feb 29, 2024
@masesdevelopers masesdevelopers added the KNetConnectSDK KNetConnectSDK related issue label Feb 29, 2024
@masesdevelopers
Copy link
Contributor Author

The code of

KNet/src/net/KNet/Specific/Connect/KNetSinkTask.cs

Line 44 in 9bf7012

public void PutInternal()
can be optimized returning an IEnumerable<SinkRecord> managed from a specific class able to use Prefetch which prepares SinkRecords while the user code uses them.

@masesdevelopers
Copy link
Contributor Author

Tests will be postponed after #429 will be closed: updates and verification will be done with latest Apache Kafka version

@masesdevelopers masesdevelopers mentioned this issue Mar 1, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@masesdevelopers masesdevelopers

Labels
KNetConnectSDK KNetConnectSDK related issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@masesdevelopers