Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newline #41

Open
Cool-Game-Dev opened this issue Dec 6, 2024 · 3 comments
Open

Newline #41

Cool-Game-Dev opened this issue Dec 6, 2024 · 3 comments

Comments

@Cool-Game-Dev
Copy link

Whenever I copy the emoji using rofi, it also copies a newline with it. Is there a fix?

@marty-oehme
Copy link
Owner

Hi @Cool-Game-Dev, do you mean when you invoke bemoji with the -c option to copy the emoji to the clipboard (bemoji -n -c) or when you use the rofi shortcut Alt+1 to copy it into the clipboard?

If it is the former, please remember to supply the -n option to remove trailing newlines.

However, I assume you mean the latter, and I think you did indeed spot a bug in the code. There are two issues here: the echo options are not correctly applied (Line 309 and the following 312) for the respective commands, and currently the echo options themselves are only set for the main command instead of for each (Line 304). These issues are definitely fixable and I can get around to them when I have some more time again.

@Cool-Game-Dev
Copy link
Author

Cool-Game-Dev commented Dec 6, 2024

@marty-oehme While I was not using Alt+1, I was pressing enter, which seems to do the same thing. In the meantime, I can use the -c -n flags, which seems to work the same way but without the trailing spaces.

@marty-oehme
Copy link
Owner

marty-oehme commented Dec 7, 2024

Yes, the default 'enter' action is sending to clipboard. The -n flag is the important one which removes the trailing newline, as described here.

edit Accidentally closed the issue - the Alt+1 newline remains to be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants