Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why shaded? #28

Open
jdillon opened this issue Mar 20, 2015 · 1 comment
Open

Why shaded? #28

jdillon opened this issue Mar 20, 2015 · 1 comment

Comments

@jdillon
Copy link

jdillon commented Mar 20, 2015

Why has guava and paranamer been shaded in? This makes this otherwise pretty lightweight library bloated and at least for myself makes it less desirable to re-use over re-implementation.

I get that some folks it may be simpler with a single jar, but in that case a shaded "attached" artifact may be simpler, and leaves those that already have rigid controls over dependencies the flexibility to use the library with-out the shaded inflation.

@martint
Copy link
Owner

martint commented Mar 20, 2015

This was to avoid exposing the dependency on guava, which could cause problems for users that rely on other possibly incompatible versions of that library. Guava is only used internally and none of its APIs are exposed by jmxutils.

I'm not against producing a self-contained version and one that declares its dependencies and only bundles the jmxutils classes. It's the first time I hear someone needing it, so that's why I never did it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants