From 006079f1376fe5e2daf0c56896b966534f789599 Mon Sep 17 00:00:00 2001
From: Sebastian Klein <sebastian.klein@marketing-factory.de>
Date: Thu, 8 Feb 2024 14:41:44 +0100
Subject: [PATCH] [BUGFIX] Check if EXT:filemetadata is installed (#9)

The commit "[BUGFIX] Render custom fields for file metadata"
introduced a new issue: the picturecredits fields were only
available if EXT:filemetadata is installed in the system.

The reason is that separate "showitem" lists for file types are
provided only by EXT:filemetadata. Using only the EXT:core version,
one can not add new fields to selected types with
ExtensionManagementUtility::addToAllTCAtypes().
---
 .../TCA/Overrides/sys_file_metadata.php       | 19 ++++++++++++++++++-
 1 file changed, 18 insertions(+), 1 deletion(-)

diff --git a/Configuration/TCA/Overrides/sys_file_metadata.php b/Configuration/TCA/Overrides/sys_file_metadata.php
index 4d40d38..50e83b3 100644
--- a/Configuration/TCA/Overrides/sys_file_metadata.php
+++ b/Configuration/TCA/Overrides/sys_file_metadata.php
@@ -203,6 +203,23 @@
 
     ExtensionManagementUtility::addTCAcolumns('sys_file_metadata', $fields);
 
+    // Only if EXT:filemetadata is not installed, we need to configure file type "2" (images) here.
+    // Otherwise, this 'showitem' list would overwrite the extension's field list.
+    if (!\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::isLoaded('filemetadata')) {
+        $GLOBALS['TCA']['sys_file_metadata'] = array_replace_recursive($GLOBALS['TCA']['sys_file_metadata'], [
+            'types' => [
+                '2' => ['showitem' => '
+                    --div--;LLL:EXT:core/Resources/Private/Language/Form/locallang_tabs.xlf:general,
+                        fileinfo, alternative, description, title, --palette--;;language,
+                    --div--;LLL:EXT:core/Resources/Private/Language/Form/locallang_tabs.xlf:categories,
+                        categories,
+                    --div--;LLL:EXT:core/Resources/Private/Language/Form/locallang_tabs.xlf:extended,
+                '],
+            ]
+        ]);
+    }
+
+    // Add custom fields only for files of type "2" (images):
     ExtensionManagementUtility::addToAllTCAtypes(
         $table,
         '
@@ -215,7 +232,7 @@
             --palette--;' . $extLL . $termsTable . '.palette.publisher;publisher;;,
             --palette--;' . $extLL . $termsTable . '.palette.disclaimer;disclaimer;;,
             --palette--;' . $extLL . $termsTable . '.palette.other;other;;,
-            --palette--;' . $extLL . $termsTable . '.palette.internal;internal;;,
+            --palette--;' . $extLL . $termsTable . '.palette.internal;internal;;
         ',
         '2',
         ''