Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to change toggle line comment shortcut #3575

Open
meszdav opened this issue Jan 25, 2025 · 4 comments
Open

Unable to change toggle line comment shortcut #3575

meszdav opened this issue Jan 25, 2025 · 4 comments

Comments

@meszdav
Copy link

meszdav commented Jan 25, 2025

Describe the bug

There is an option to customize all shortcuts, but the toggle line comment shortcut is currently not modifiable.

Please add support to allow modifying the Toggle Line Comment shortcut!

Image

Environment

{
  "marimo": "0.10.17",
  "OS": "Darwin",
  "OS Version": "24.1.0",
  "Processor": "arm",
  "Python Version": "3.13.1",
  "Binaries": {
    "Browser": "131.0.6778.267",
    "Node": "v23.4.0"
  },
  "Dependencies": {
    "click": "8.1.8",
    "docutils": "0.21.2",
    "itsdangerous": "2.2.0",
    "jedi": "0.19.2",
    "markdown": "3.7",
    "narwhals": "1.23.0",
    "packaging": "24.2",
    "psutil": "6.1.1",
    "pygments": "2.19.1",
    "pymdown-extensions": "10.14.1",
    "pyyaml": "6.0.2",
    "ruff": "0.9.3",
    "starlette": "0.45.3",
    "tomlkit": "0.13.2",
    "typing-extensions": "4.12.2",
    "uvicorn": "0.34.0",
    "websockets": "14.2"
  },
  "Optional Dependencies": {
    "altair": "5.5.0",
    "pandas": "2.2.3",
    "pyarrow": "19.0.0"
  },
  "Experimental Flags": {}
}

Code to reproduce

No response

@meszdav meszdav added the bug Something isn't working label Jan 25, 2025
@mscolnick mscolnick removed the bug Something isn't working label Jan 25, 2025
@mscolnick
Copy link
Contributor

This is by design (not a bug) but we can consider allowing customization.

@meszdav
Copy link
Author

meszdav commented Jan 25, 2025

It would be very helpful because not all keyboard languages allow the use of the default value.

@mscolnick
Copy link
Contributor

Oh that's good to know. I was unaware. What language keyboard?

@meszdav
Copy link
Author

meszdav commented Jan 26, 2025

I am using german layout. I can write forward slash with shift+7 however the combination cmd+shift+7 does not work for toggle line comment and it would not be too convenient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants