Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to contribute to local development #20

Open
mcmxcdev opened this issue Oct 21, 2024 · 5 comments · May be fixed by #21
Open

Unable to contribute to local development #20

mcmxcdev opened this issue Oct 21, 2024 · 5 comments · May be fixed by #21

Comments

@mcmxcdev
Copy link
Contributor

I was struggling to get the extension to show up in "Extensions" application.

That's because when running npm run build and npm run linkdist, a symlink to dist is created as shown in the image below BUT the dist files need to put into this directory directly like shown too:

image

Long story short: instead of symlinking the dist folder over as a whole, it might be better to just copy the contents of the dist folder over and overwrite any files already existing in the extensions directory.
@marcinjahn
Copy link
Owner

I guess that's because you already had the extensions installed before you did the local build. I think if you uninstall the extension from the store first, and then invoke the linkdist, it should work? I haven't developed any extension since quite some time, but the setup that is there always did work.

@mcmxcdev
Copy link
Contributor Author

I have tried that: I removed all the files that are inline in the screenshot above and kept only the dist folder, the extension didn't show up at all then, even after a re-login to the Wayland session.

@marcinjahn
Copy link
Owner

You should remove the entire [email protected] directory. Only then it will work.

@marcinjahn
Copy link
Owner

marcinjahn commented Oct 22, 2024 •
edited
Loading

the linkdist command could maybe be just updated to rm "$HOME/.local/share/gnome-shell/extensions/[email protected]" && ln -s "$PWD/dist" "$HOME/.local/share/gnome-shell/extensions/[email protected]"?

@marcinjahn
Copy link
Owner

if you think that'd solve the problem, feel free to create a PR with such change.

@mcmxcdev mcmxcdev linked a pull request Oct 22, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove extension folder before linking dist mcmxcdev/gnome-peek-top-bar-on-fullscreen-extension
2 participants
@marcinjahn @mcmxcdev