Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only compare packages exported by modules #179

Open
AlanBateman opened this issue Oct 2, 2023 · 3 comments
Open

Only compare packages exported by modules #179

AlanBateman opened this issue Oct 2, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@AlanBateman
Copy link

Looking at this page:
https://javaalmanac.io/jdk/22/apidiff/21/

where it shows a new method added to java.awt.peer.WindowPeer. This is confusing to see because this is an internal class, the java.awt.peer package is not an exported/documented/supported interface. The diff tool shouldn't be looking at APIs in non-exported packages.

@marchof
Copy link
Owner

marchof commented Oct 2, 2023

You're right. Currently I simply filter by package name. It's on my todo list since quite some time to consider the exports in module-info.class.

@marchof marchof changed the title java.desktop/java.awt.peer is not exported Only compare packages exported by modules Oct 2, 2023
@marchof marchof added the enhancement New feature or request label Oct 2, 2023
@marchof
Copy link
Owner

marchof commented Oct 4, 2023

I run a prototype: java.awt.peer is the only instance where a java.* package is not exported in the JDK.

@AlanBateman
Copy link
Author

I run a prototype: java.awt.peer is the only instance where a java.* package is not exported in the JDK.

That's right, the peers were developed in this package a long time ago but never part of the documented/supported API. When the platform moved to modules in Java 9, the java.awt.peer package was not exported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants