Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to latest mapnik-vector-tile version #942

Open
artemp opened this issue Jan 27, 2020 · 3 comments
Open

Upgrade to latest mapnik-vector-tile version #942

artemp opened this issue Jan 27, 2020 · 3 comments
Assignees
@artemp

Comments

@artemp
Copy link
Member

artemp commented Jan 27, 2020 •
edited
Loading

While digging into compiler warnings I noticed we're still using mapnik-vector-tile 2.2.1 in https://github.com/mapnik/node-mapnik/blob/master/package.json#L39

Latest master has some important fixes and builds cleanly (no warnings) for me, shouldn't we upgrade? /cc @springmeyer @jseppi
@artemp artemp self-assigned this Jan 27, 2020
@springmeyer
Copy link
Member

👍 to upgrading.

artemp added a commit that referenced this issue Jan 27, 2020
@artemp
Upgrade to mapnik-vector-tile 3.0.1 (ref #942)
415b2a2
@Algunenano
Copy link
Contributor

You might want to update wagyu too. 0.5.0 should be faster in some cases and more robust.

@artemp
Copy link
Member Author

artemp commented Jan 28, 2020

@Algunenano - good call, I'll take a look, thanks.

artemp added a commit that referenced this issue Jan 31, 2020
@artemp
Merge pull request #943 from mapnik/[email protected]
ec84f14 
Upgrade to mapnik-vector-tile 3.0.1 (ref #942)
Upgrade deps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@artemp artemp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@springmeyer @artemp @Algunenano