You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Maputnik currenlly does request /font/%7Bfontstack%7D/%7Brange%7D to query for fonts if ran against maplibre/martin.
This is the case because the orinal font url is /font/{fontstack}/{range}.
As the .pbf ending that maputnik assumes does not exist, the replacement on line 30 below does not happen.
Related PR on martins side which we did not get done yet:
Maputnik expects to recieve an array of possible fontstacks.
Feature Request
would it be possible to request these 3 URLs in paralel and accept the first successfull response or would the overhead be too high on the maputnik side?:
We could handle this in martin. I am unsure what is the best option here.
A hybrid approach would be to drop the .pbf requirement in below code and implement serving under the replace(normPathPart, '.json')-Url in martin
PS: I have a bit of time in my cristmas break to look into implementing this.
I think I am missing a bit of context as the code relevant seems a bit strange
The text was updated successfully, but these errors were encountered:
Created from:
Closely related to:
Problem
Maputnik currenlly does request
/font/%7Bfontstack%7D/%7Brange%7D
to query for fonts if ran againstmaplibre/martin
.This is the case because the orinal font url is
/font/{fontstack}/{range}
.As the
.pbf
ending that maputnik assumes does not exist, the replacement on line 30 below does not happen.Related PR on martins side which we did not get done yet:
Maputnik expects to recieve an array of possible fontstacks.
Feature Request
would it be possible to request these 3 URLs in paralel and accept the first successfull response or would the overhead be too high on the maputnik side?:
/fontstack.json
replace(normPathPart, '.json')
/catalog
Alternatives
We could handle this in martin. I am unsure what is the best option here.
A hybrid approach would be to drop the
.pbf
requirement in below code and implement serving under thereplace(normPathPart, '.json')
-Url in martinAdditional Context
maputnik/src/libs/metadata.ts
Lines 20 to 35 in c6174a5
CC @nyurik @artyomb
Note
PS: I have a bit of time in my cristmas break to look into implementing this.
I think I am missing a bit of context as the code relevant seems a bit strange
The text was updated successfully, but these errors were encountered: