Fix network issue #944
Open
Fix network issue #944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pathmapper
reviewed
Sep 30, 2024
HarelM
commented
Sep 30, 2024
HarelM
commented
Sep 30, 2024
nyurik
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
LGTM.
one side question - can't we use a much more readable await syntax?
try {
let response = await fetch(url, {
mode: 'cors',
credentials: "same-origin"
});
if (!response.ok) {
throw new Error('Failed to load metadata for ' + url);
}
cb(await response.json())
}
catch (ex) {
console.warn('Can not load metadata for ' + url + ', using default value ' + defaultValue);
cb(defaultValue)
}
|
We could, I didn't want to change the code a lot ,and only wanted to solve this issue. It can be done as part of a different PR... |
|
In general, this callback hell should be removed, much like we did for maplibre, but it's not a small change... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Launch Checklist
In case of non 200 response the font and glyphs metadata would return the ajax error object instead of the default value.
Fixes #935
Crash - TypeError: i.map is not a function #935
Briefly describe the changes in this PR.
Link to related issues.
Include before/after visuals or gifs if this PR includes visual changes.
Write tests for all new functionality.
Add an entry to
CHANGELOG.mdunder the## mainsection.