Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade codemirror #891

Open
HarelM opened this issue Mar 21, 2024 · 0 comments
Open

Upgrade codemirror #891

HarelM opened this issue Mar 21, 2024 · 0 comments

Comments

@HarelM
Copy link
Collaborator

HarelM commented Mar 21, 2024

Maputnik currently uses codemirror 5, but codemirror 6 is avaiable, but they have changed the API dramatically.
Some of it is explained here:
https://codemirror.net/docs/migration/
But there are a lot of things that needs to be defined and updated and I'm not familiar enough with the original definitions and requirements in order to "safely" update this package.
If anyone is familiar with codemirror enough to easily update the package it may be helpful.

HarelM added a commit that referenced this issue Mar 21, 2024
This PR aims at updating some packages.
I'll keep this in draft until I'll be more happy with the results.
Current setup seems to work, I'll let the CI run and see how bad this
is.
Packages that needs to be updated/replaces:
- [x] ~autocompete - The only warning left in the console is related to
the autocomplete, which probably needs to be updated since it's a
package that wasn't updated in the last 6 years.~ #611
- [x] ~Codemirror is also something that will need an update, but it
looks too complicated at this point in time, so let's see how this
goes.~ #891
- [ ] react-color
- [x] ~react-aria-menubutton~ #846
- [ ] Others?

Most of the changes here are related to types, which is good.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant