Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Php DBC library #3

Open
ghost opened this issue Jul 21, 2012 · 4 comments
Open

Integrate Php DBC library #3

ghost opened this issue Jul 21, 2012 · 4 comments
Labels

Comments

@ghost
Copy link

ghost commented Jul 21, 2012

Instead of hardcoded DBC reading we should use timkurvers/wow-dbc library as it provides a clean interface for reading and writing DBC files.

@ghost ghost self-assigned this Jul 21, 2012
@Nanaki52
Copy link
Contributor

The library does not provide a way to insert data directly into a database, so something like the extract script actually in use would not be possible unless we edit the library.
Also, it does not provide any way to filter the fields and choose the ones to extract, so the full content of every dbc would be inserted.
So it's doable, with a bit of work. The second point is neglectable, but the first isn't unless the final user is supposed to import himself all the sql batch files generated by the library :P

Started working on it (https://github.com/Nanaki52/tracker), probably there are better ways to do it, I don't know any other though.

@shlainn
Copy link
Contributor

shlainn commented Jul 25, 2012

Personally, while I agree that the current system is about as comfortable as a rock in a hard place (I wrote it ;) ), I do not see the need to add a full library (we will not be writing DBC files, will we?) for a step which is done ONCE during SETUP and will rarely, if ever require modification. IMHO the DBC format is simple and well-documented enough to not put any additional effort into this.

@ghost
Copy link
Author

ghost commented Sep 17, 2012

I have pushed an updated version of the DBC library accompanied by mappings for all 1.12 DBC files. There are a only five or six fields, which I could not resolve or cross-reference to other fields.

@ghost
Copy link
Author

ghost commented Sep 17, 2012

Started working on it (https://github.com/Nanaki52/tracker), probably there are better ways to do it, I don't know any other though.

Can you try the updated php-dbc library I pushed? It comes with batteries included, meaning it does have DBC mappings for all files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants