Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shortcut icon for .py and .bat files #675

Closed
Ana06 opened this issue Sep 29, 2023 · 2 comments · Fixed by #858
Closed

Fix shortcut icon for .py and .bat files #675

Ana06 opened this issue Sep 29, 2023 · 2 comments · Fixed by #858
Assignees
Labels
🐛 bug Something isn't working 🌀 FLARE-VM A package or feature to be used by FLARE-VM

Comments

@Ana06
Copy link
Member

Ana06 commented Sep 29, 2023

VM-Install-From-Zip is being used for .py and .bat files, but the icon in the shortcut doesn't seem to work well in these cases.

Related #674

@Ana06 Ana06 added the 🐛 bug Something isn't working label Sep 29, 2023
@Ana06 Ana06 added this to the FLARE-VM 2023 Q4 milestone Sep 29, 2023
@Ana06 Ana06 self-assigned this Sep 29, 2023
@Ana06 Ana06 added the 🌀 FLARE-VM A package or feature to be used by FLARE-VM label Oct 17, 2023
@Ana06 Ana06 removed their assignment Oct 26, 2023
@Ana06
Copy link
Member Author

Ana06 commented Jan 22, 2024

@emtuls this issue is related to other issues you have worked on recently. Would you like to work on it? 😄

@emtuls
Copy link
Member

emtuls commented Jan 22, 2024

@Ana06 Sure thing! Do you have any examples of which ones do this and what their icon's should be? Or is this something that you want to have be detected and attempt to set the shortcut icon accordingly?

  • It may be possible to detect that a shortcut to a python file is being created and I could have it point to python.exe to use for the default shortcut icon if none is provided?
  • Similarly, I could try to do the same for .bat files after we determine which icon to use (the normal .bat icon isn't easily available)

A quick look for Python ones show: ida.diaphora.vm and didier-stevens-beta/suite.vm and I noticed this about these packages:

  • ida.diaphora.vm is not intended to be run as a python script directly, so I'm not sure if we want to modify this one?
  • didier-stevens-beta/suite.vm installs a lot of tools, but each shortcut may not work properly if something like VSCode is installed, since it will ask how to open the file.
    • To mitigate this, we can use Python in the shortcut's Target so that it always knows to execute the file with Python.

For the python ones, I defaulted to using the icon from python.exe and I will also write a fix for the didier-stevens-beta/suite.vm packages so that the shortcuts work out of the box.

For .bat files, I will try to find a suitable icon to use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working 🌀 FLARE-VM A package or feature to be used by FLARE-VM
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants