Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default python version #337

Closed
Ana06 opened this issue May 17, 2023 · 5 comments
Closed

Default python version #337

Ana06 opened this issue May 17, 2023 · 5 comments
Labels
❔ discussion Further discussion is needed

Comments

@Ana06
Copy link
Member

Ana06 commented May 17, 2023

We are installing python3 libraries using python 3.9 in libraries.python3.vm. But some other packages require a different python version. For example:

So if we install libraries.python3.vm and then adconnectdump.vm the path will looks something like this:

C:\Python27\;C:\Python27\Scripts;C:\Python39\Scripts\;C:\Python39\;C:\ProgramData\Boxstarter;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0\;C:\Windows\System32\OpenSSH\;C:\ProgramData\chocolatey\bin;C:\Program Files\010 Editor;C:\Users\flare\AppData\Local\Microsoft\WindowsApps;

Which means that python will use python2 by default. This tools don't really need the python version added to the path, just the tool executable.

How should we handle this?

We could add a function in common that could reorder the path to ensure python3.9 is on top and call it from these kind of package. What do you think? Other ideas?

@Ana06 Ana06 added the ❔ discussion Further discussion is needed label May 17, 2023
This was referenced May 17, 2023
@Ana06
Copy link
Member Author

Ana06 commented May 17, 2023

One workaround while we find a better solution is to ensure we install the packages in the right order. But we should implement something better in the long term.

@Ana06
Copy link
Member Author

Ana06 commented May 22, 2023

I am trying to update stringsifter to Python 3.9.

For the packages that don't run in Python 3.9, we could display a warning message in the package and let the user handle this (by installing packages in the right order of fixing the path manually).

@Ana06
Copy link
Member Author

Ana06 commented May 23, 2023

In #331 stringsifter is installed in Python 3.9. adconnectdump.vm is the only package that uses a Python version different than 3.9.

So I suggest:

  • Python 3.9 is the default Python version which should be added as dependency when creating a package that needs Python.
  • For packages that can not be installed in Python 3.9, we display a warning (the warning should be a helper in common).
  • The user (individual user, but also any consumers of VM-Packages like FLARE-VM) is responsible to install packages in the correct order or restore the path.

All this needs to be documented. @vm-packages do we agree on this? If so, I can take care of documenting this.

@mr-tz
Copy link
Contributor

mr-tz commented May 24, 2023

Sounds good to me

@Ana06
Copy link
Member Author

Ana06 commented Oct 4, 2023

Partially resolved. Rest tracked in #673

@Ana06 Ana06 closed this as completed Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
❔ discussion Further discussion is needed
Projects
None yet
Development

No branches or pull requests

2 participants