Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove microsoft-windows-terminal.vm exclusion in CI #1062

Open
Ana06 opened this issue May 29, 2024 · 0 comments
Open

remove microsoft-windows-terminal.vm exclusion in CI #1062

Ana06 opened this issue May 29, 2024 · 0 comments
Assignees
Labels
💎 enhancement It is working, but it could be better

Comments

@Ana06
Copy link
Member

Ana06 commented May 29, 2024

Details

We renamed microsoft-windows-terminal.vm to windows-terminal.vm in #936. We had excluded this package from the 2019 test because it was failing: https://github.com/mandiant/VM-Packages/blob/main/.github/workflows/ci.yml#L47, but we forgot to rename the exclude package, which means the package seems to install correctly in 2019 and the exclusion doesn't seem to be needed anymore. Or am I missing something?

@Ana06 Ana06 added the 💎 enhancement It is working, but it could be better label May 29, 2024
@Ana06 Ana06 added this to the FLARE-VM 2024 Q2 milestone Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💎 enhancement It is working, but it could be better
Projects
None yet
Development

No branches or pull requests

2 participants