Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] iCloud Photos Shared Library Support #106

Closed
coughlanio opened this issue Jan 8, 2023 · 6 comments · Fixed by #156
Closed

[FEATURE] iCloud Photos Shared Library Support #106

coughlanio opened this issue Jan 8, 2023 · 6 comments · Fixed by #156
Assignees
Labels
new feature New feature or request
Milestone

Comments

@coughlanio
Copy link

Use case
As an iOS 16 user, I want the ability to backup both shared and personal photo libraries

Describe the solution you'd like
I had a quick look at icloudpy and I wasn't able to find any references to iOS 16's shared photo library feature. I'm currently looking for a tool that will allow me to do so.

Describe alternatives you've considered
I currently use icloudpd, but it ran into some issues with shared libraries, so the feature was removed from main.

Additional context
boredazfcuk/docker-icloudpd#239

@mandarons mandarons added this to the 1.11.0 milestone Jan 10, 2023
@mandarons mandarons added the new feature New feature or request label Jan 10, 2023
@mandarons mandarons modified the milestones: 1.11.0, Future Jan 14, 2023
@tymmej
Copy link
Contributor

tymmej commented Oct 5, 2023

Recently iCloud-drive-docker added support for Shared libraries.

Using pyicloud_pd from that project I hacked initial support for shared libraries: https://github.com/tymmej/icloud-drive-docker/tree/shared_library

Currently there's some limitations:

  • no option to list libraries (must add print to code to view it)
  • Shared libraries do not support albums - maybe it is limitation of API. In browser there's info that albums are not (yet) supported on iCloud.com
  • I didn't test drive sync with pyicloud_pd
  • I copied support for subalbums from https://github.com/mandarons/icloudpy to icloudpy
  • I modified 2FA flow

I wanted to ask if there's any plans to support shared libraries.
If yes should we add support for shared libraries to icloudpy or use pyicloud_pd?
@mandarons do you have any thoughts what should be next steps?

@mandarons
Copy link
Owner

Absolutely! In general, whatever you see in next-gen milestone is planned to be done in near future. Shared Libraries support is one of them.

For this feature, we need to split the implementation in two - icloudpy and iCloud-drive-docker projects. Not sure what needs to be changed in iCloud-drive-docker just yet but icloudpy certainly needs to be changed.

@tymmej
Copy link
Contributor

tymmej commented Oct 5, 2023

Changes to iCloud-drive-docker seems minimal (using pyicloud_pd):

-                album=photos.albums[album],
+                album=photos.libraries[library].albums[album],

in 3 places in sync_photos.py and few lines to add support for library key in config.yaml.

I did not analyze library changes.

@mandarons mandarons modified the milestones: next-gen, 1.60.0 Oct 5, 2023
@mandarons
Copy link
Owner

Great. Looks like this can be targeted to 1.16.0 release.

@mandarons
Copy link
Owner

Here is equivalent issue for icloudpy mandarons/icloudpy#13 (for reference)

@tymmej
Copy link
Contributor

tymmej commented Oct 5, 2023

I created initial PR: #156

@mandarons mandarons linked a pull request Oct 6, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants