We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Certain basic_string operations (such as comparisons) can be implemented in terms of basic_string_view: e.g.:
bool operator==(const basic_string &other) const { return basic_string_view<Char>{_buffer, _length} == basic_string_view<Char>{other._buffer, other._length}; }
We could also add a convenience basic_string::view() method that does the view construction.
basic_string::view()
Doing this will allow us to more easily prevent bugs like the one fixed by 264af2d.
The text was updated successfully, but these errors were encountered:
string: deduplicate comparison logic between string and string_view
c9a732b
Fixes managarm#36.
Successfully merging a pull request may close this issue.
Certain basic_string operations (such as comparisons) can be implemented in terms of basic_string_view: e.g.:
We could also add a convenience
basic_string::view()
method that does the view construction.Doing this will allow us to more easily prevent bugs like the one fixed by 264af2d.
The text was updated successfully, but these errors were encountered: