-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storage access framework corrupts files on save #17
Comments
Thank you for reporting this. I'm not seeing this when editing files in ViperEdit from MGit via SAF, so I think this is Termux specific. Does this happen with all files or only ones of a specific size or file type? If you could provide a set of steps that consistently reproduce the problem, that would be great. |
Just tested a simple file in the root of termux:
|
I can't reproduce this. |
Interesting, what android/termux versions do you have? Mine: |
Another thing I am using Gboard keyboard, will try to test with somethig else. |
Redmi Note 7; LineageOS 18.1-20220503-NIGHTLY-lavender (Android 11); Termux 0.118.0 |
Upgraded termux to 118, same issue. |
Tested on termux 116 + fire os 7 (android 9) also work fine. |
Still having this issue when editing files on my phone, this time I realized that editor adds few random chars at the end of the file right after opening it (before saving) as I can see vim on termux still shows correct content. |
Sorry I am going mad, after seeing good content in vim and NOT saving bad one in Viper I did git add and still found bad content in git diff --cached. |
Not sure if this project is still active, but I have the same issue when using Turbo Edit. Was going to try this program, as it's a fork, but it looks like it may have the same issue. Samsung Galaxy S20 5G; OneUI 5.1; Android 13 |
@SunDevil311 could you provide more details about the issue you are seeing when using Viper Edit? |
@maks Looks like I jumped the gun, not available in the Play Store for my device. I'd have to look into how to compile the program using gradle I guess, not something I typically do. I just turned off the Storage Access Framework toggle on Turbo Edit and it works fine for now... |
@SunDevil311 thanks for letting me know, the app is not available on Play because I hadn't yet provided some admin policy details to Google Play. I've done that now, so the app should be available for install again soon |
@maks Wanted to update you on this. I was not able to download Viper Edit via Google Play, as I'm still receiving a message that it's incompatible I was able to acquire the installer via APKMirror and have not had any issues since installing. Overall, great app for what I'm looking for. |
I've not had any of the issue with SAF that have been reported. Thus far, Viper seems to be a faithful fork of Turbo Edit that doesn't share the same issues (namely, issues with SAF). Also, this app is still not showing up in the Play Store. If F-Droid is an option, that'd be great too, or even a standalone APK. I realize this project hasn't been updated for a while, but it's quite functional. Just be a shame if a small group of people is all that know of it. |
@SunDevil311 hmm thats unexpected, Viper Edit should be available on Google Play now that I've updated the required policy data and I see new installs happening regularly so I'm not sure why you are not able to see on Play. |
@maks To be precise, Viper Edit does show up in the Play Store. However, it tells me that it's not compatible with my device. I'm using a Galaxy S20 (unrooted) on Android 13, I would think I should be able to run it (I do, from a manual APK install). One of my family member devices' is compatible, as I've shown in the screenshot. You can't see the details of the SM-G981U (Galaxy S20), but it gives the same message as Chromecast. |
Probably you need to increase the target API version for Viper Edit. Google Play got quite restrictive in these terms recently... |
@SunDevil311 sorry Im not sure why this would be the case, you can see in the manifest there are basically no requirements on what the device needs to support. @fm-sys No I don't think that is the case, as I've been able to install it on Pixel running Android 13 today without any issues. |
It's not about technical incompatibility but a Google Play requirement:
https://support.google.com/googleplay/android-developer/answer/11926878 But maybe there are exceptions if you previously already had installed the app. |
Ah good point @fm-sys I missed the wording "...to new users" when I previously read that statement from Google. I'll need to update the app to target a higher API level as currently it does indeed target 29, although that may take some time as previously I've run into other restrictions that are applied once an app targets newer API levels. |
I am using ViperEdit (and TurboEdit before) to edit files in Termux through Storage Access Framework.
Every time I remove lines from a file and save it saves some random lines to the end of it.
I am not sure if this is an issue with ViperEdit, SAF or Termux :( but it is super annoying to always go to Termix and delete garbage lines from the end using good old vim :)
I use Termux for git as mGit cannot handle any non-small git repos unfortunately.
The text was updated successfully, but these errors were encountered: