Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add horizontal Swipe gesture to change tabs #42

Open
maheshj01 opened this issue Mar 22, 2024 · 7 comments
Open

Add horizontal Swipe gesture to change tabs #42

maheshj01 opened this issue Mar 22, 2024 · 7 comments
Labels
Feature Request New feature or request P3 Low priority (default) for the features/bugs that will be worked on in near future

Comments

@maheshj01
Copy link
Owner

Is your feature request related to a problem? Please describe.
Add a horizontal Swipe Gesture to change the tabs, This should be configurable with a swippable parameter, We should also investigate if this does not interfere when the UI contains a horizontal scrollable or a draggable widget

Additional context
Add any other context or screenshots about the feature request here.

@maheshj01 maheshj01 added Feature Request New feature or request P3 Low priority (default) for the features/bugs that will be worked on in near future labels Mar 22, 2024
@bebaoboy
Copy link
Contributor

Have you implemented this feature?
Can you give me a summary of some other PR and Issues are still active? Please sent me here or via work email. I wanna work on them but there are a lot, both fixed and not fixed yet. Thank you 😅.

@maheshj01
Copy link
Owner Author

maheshj01 commented Apr 21, 2024

@bebaoboy All the issues are upto date, if they are open they are not yet implemented. You are welcome to send PR. And if you are interestd in working on any of the issue and need any additional info or pointers to begin, Please feel free to leave a comment on that issue.

@bebaoboy
Copy link
Contributor

Hi, do you think there is any drawback when using PageView to implement this?

@maheshj01
Copy link
Owner Author

maheshj01 commented Jun 30, 2024

I think PageView is a great choice to solve it, We just need to check if using PageView would hinder horizontal list inside the PageView or a draggable

@bebaoboy
Copy link
Contributor

I believe we cannot use PageView (horizontal direction) and some other horizontal Scrollables without problems (aka the PageView would just block the inner scrollable).

So I think using CustomScrollView with Sliver stuff is better. But instead of doing all the hassles, maybe check this library out: nested_scroll_views.

@maheshj01
Copy link
Owner Author

Thanks for checking that out, But I don't think this package should depend on external libraries for such core features, It can be difficult to maintain in the long run and could add a severe code debt. I would go trying some proof of concept with CustomScrollView or PageView.

@bebaoboy
Copy link
Contributor

bebaoboy commented Jul 4, 2024

Alright I understand about the code debt and potential maintenance issue. Thanks for telling me. I'll just use it as a case study and maybe try to play around it a lil bit. Have a good day! 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request New feature or request P3 Low priority (default) for the features/bugs that will be worked on in near future
Projects
None yet
Development

No branches or pull requests

2 participants